HI Adrian,
I did end up redoing the tag building using the remote method vs local cloning with git tags. About 11-13 seconds vs 1:18-1:20 which is fast enough that I am now doing it dynamically inside build_zimbra.sh instead of calling an external tag helper and using cached files containing prebuilt tags with your helper scripts. It also simplifies the builds for novices as they only need to know --version option to reliably build new releases for themselves on any of the supported platforms.While we don't need tag files, I did leave in the option to do this:Here are the timing comparisons:vsA few changes from how you do it:
* I kept it as a single bash script which ment I had to call perl in a bash function to load the list of repositories. My goal was to keep it as a single bash script.
* I am not pulling the development branch of zm-build in tag generation as some repositories were needed for earlier builds that had been removed in later branches to allow the script to retain its ability to build specific and older versions. I don't have that need myself but saw this in testing so went with the highest tag for zm-build instead of the latest zm-build during this initial phase.
That isn't a problem for MALDUA's builds as you generate the latest builds for each release so any deleted repositories found in zm-build would not be a problem.
Other than that, tags are identical for version 9.0, 10.0, and 10.1 according to diff (after removed extra \n) but from a completely different code base which gives us another sanity check for building FOSS releases by version/tag.
Jim
I did end up redoing the tag building using the remote method vs local cloning with git tags. About 11-13 seconds vs 1:18-1:20 which is fast enough that I am now doing it dynamically inside build_zimbra.sh instead of calling an external tag helper and using cached files containing prebuilt tags with your helper scripts. It also simplifies the builds for novices as they only need to know --version option to reliably build new releases for themselves on any of the supported platforms.
Code:
% ./build_zimbra.sh --version 10.1Code:
% ./build_zimbra.sh --tags10.1% ./build_zimbra.sh --tags # build latest tag files for 8.8.15, 9.0, 10.0, and 10.1Code:
% time ./zm-build-filter-tags-9.sh......9.0.0.p41,9.0.0.p40,9.0.0.p39,9.0.0.p38,9.0.0.p37,9.0.0.p36,9.0.0.p34,9.0.0.p33,9.0.0.P33,9.0.0.p32.1,9.0.0.p32,9.0.0.p30,9.0.0.p29,9.0.0.p28,9.0.0.p27,9.0.0.p26,9.0.0.p25,9.0.0.p24.1,9.0.0.p24,9.0.0.p23,9.0.0.p22,9.0.0.p21,9.0.0.p20,9.0.0.p19,9.0.0.p18,9.0.0.p17,9.0.0.p16,9.0.0.p15,9.0.0.p14,9.0.0.p13,9.0.0.p12,9.0.0.p11,9.0.0.p10,9.0.0.p9,9.0.0.p8,9.0.0.p7,9.0.0.p6,9.0.0.p5,9.0.0.p4,9.0.0.p3,9.0.0.p2,9.0.0.p1,9.0.0111.095u 12.800s 1:18.11 158.6%0+0k 160+2348440io 3pf+0wCode:
% time ./build_zimbra.sh --tags9.0Building tags for version 9.0.............1.157u 0.853s 0:12.31 16.2%0+0k 0+3968io 0pf+0w% cat tags_for_9_0.txt 9.0.0.p41,9.0.0.p40,9.0.0.p39,9.0.0.p38,9.0.0.p37,9.0.0.p36,9.0.0.p34,9.0.0.p33,9.0.0.P33,9.0.0.p32.1,9.0.0.p32,9.0.0.p30,9.0.0.p29,9.0.0.p28,9.0.0.p27,9.0.0.p26,9.0.0.p25,9.0.0.p24.1,9.0.0.p24,9.0.0.p23,9.0.0.p22,9.0.0.p21,9.0.0.p20,9.0.0.p19,9.0.0.p18,9.0.0.p17,9.0.0.p16,9.0.0.p15,9.0.0.p14,9.0.0.p13,9.0.0.p12,9.0.0.p11,9.0.0.p10,9.0.0.p9,9.0.0.p8,9.0.0.p7,9.0.0.p6,9.0.0.p5,9.0.0.p4,9.0.0.p3,9.0.0.p2,9.0.0.p1,9.0.0* I kept it as a single bash script which ment I had to call perl in a bash function to load the list of repositories. My goal was to keep it as a single bash script.
* I am not pulling the development branch of zm-build in tag generation as some repositories were needed for earlier builds that had been removed in later branches to allow the script to retain its ability to build specific and older versions. I don't have that need myself but saw this in testing so went with the highest tag for zm-build instead of the latest zm-build during this initial phase.
That isn't a problem for MALDUA's builds as you generate the latest builds for each release so any deleted repositories found in zm-build would not be a problem.
Other than that, tags are identical for version 9.0, 10.0, and 10.1 according to diff (after removed extra \n) but from a completely different code base which gives us another sanity check for building FOSS releases by version/tag.
Jim
Statistics: Posted by JDunphy — Tue Sep 03, 2024 6:42 pm