It looks like it is not possible to create issues in GitHub, and I don't want to submit a pull request without having a build environment set up, but I have investigated this further. These seem to be two separate but related bugs.
The underlying issue is when there is an "Organizer" but the organizer has a null email address.
In the first case, where the entry cannot be deleted, I believe the logic in CalendarItem.java:2377 is faulty (https://github.com/Zimbra/zm-mailbox/bl ... rItem.java):This function organizerChangeCheck() is attempting to prevent disallowed modification to the organizer address of a calendar item. The logic identifies the new organizer address to null as a change, but it should not consider this so if the old address was also null. (It is a good question on if this should ever be allowed to be null, but empirically it can happen today.) Changing the logic to the following is the simplest fix, but an audit of null orgAddrs is recommended:That's a bit ugly, but for likely good reasons CalendarUtils.belongToSameAccount() returns false when either address is null.
The underlying issue is when there is an "Organizer" but the organizer has a null email address.
In the first case, where the entry cannot be deleted, I believe the logic in CalendarItem.java:2377 is faulty (https://github.com/Zimbra/zm-mailbox/bl ... rItem.java):
Code:
if (newOrgAddr == null || !CalendarUtils.belongToSameAccount(origOrgAddr, newOrgAddr)) {Code:
if ((newOrgAddr == null && oldOrgAddr != null) || !CalendarUtils.belongToSameAccount(origOrgAddr, newOrgAddr)) {Statistics: Posted by jered — Tue Jan 02, 2024 7:43 pm
